Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested extension continued #8

Closed
kirtsar opened this issue Jan 18, 2020 · 2 comments
Closed

Nested extension continued #8

kirtsar opened this issue Jan 18, 2020 · 2 comments

Comments

@kirtsar
Copy link
Contributor

kirtsar commented Jan 18, 2020

  1. There are no checks that the minimal polynomial is irreducible. Is it intended?
F2 = @GaloisField 2
F4 = @GaloisField! F2 x^2
@show x^(-1)
  1. Not possible to use coefficients from field in irreducible polynomial in macro?
F2 = @GaloisField 2
F4 = @GaloisField! F2 x^2 + x + 1
# t^3 + x is irreducible over F4
@GaloisField! F4 t^3 - x
# ERROR: LoadError: Polynomials must have same variable
# However, the straight construction works well:
F64 = GaloisField(F4, :t => [1, 0, 0, x])
@tkluck
Copy link
Owner

tkluck commented Jan 18, 2020

Both are very reasonable feature requests. I'll separate the issues if you don't mind.

@tkluck
Copy link
Owner

tkluck commented Jan 18, 2020

Closing this issue just for bookkeeping. Feel free to open (separate) issues for any other feature requests / bugs.

@tkluck tkluck closed this as completed Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants