Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "indexFromEmptyFile" to "index" #20

Closed
ishitatsuyuki opened this issue Mar 19, 2018 · 4 comments
Closed

Rename "indexFromEmptyFile" to "index" #20

ishitatsuyuki opened this issue Mar 19, 2018 · 4 comments
Assignees
@tkoenig89
Labels
enhancement

Comments

@ishitatsuyuki
Copy link

It's how it's called in serve-static. Renaming it allows easier migration from serve-static.
@tkoenig89
Copy link
Owner

Good point. Thanks for pointing this out.

I guess i will add the "index" option and leave the other one for now, to prevent breaking the module for others.

@tkoenig89 tkoenig89 self-assigned this Mar 20, 2018
@tkoenig89
Copy link
Owner

Update: my latest commit adds the index option. It will be part of the next release.

@tkoenig89
Copy link
Owner

This feature is now part of version 1.0.0 which has just been released to npm.

@tkoenig89
Copy link
Owner

Closed, as this has been released a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkoenig89 tkoenig89

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkoenig89 @ishitatsuyuki