Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARIA attributes for better Accessiblity #22

Closed
tkshill opened this issue Oct 6, 2020 · 3 comments
Closed

Add ARIA attributes for better Accessiblity #22

tkshill opened this issue Oct 6, 2020 · 3 comments
Assignees
Labels
Context: Accessibility Making interaction better for Everyone hacktoberfest tag for issues meant to be tackled during hacktoberfest. Status: Assigned Someone is already working on this issue Type: Enhancement New feature or request
Milestone

Comments

@tkshill
Copy link
Owner

tkshill commented Oct 6, 2020

Issue Context

Our main page elements do not have the appropriate Accessible Rich Internet Applications (ARIA) labels. This makes it harder for people with disabilities to navigate the site.

Suggested Solution

Add as many of the accessbility attributes in the Elm-ui region library as are applicable. In particular:

  • Add the navigation attribute msg to the row element containing the links in the Shared.elm view function.
  • Add the mainContent attribute msg to the column containing the page.body.
  • Add the announce attribute message to the top level column in the viewBoard function.

Alternatives Considered

Additional Resources

See here in the read me for how to run and install the application.

See here in contributing for the basics on forking and cloning the repository.

@tkshill tkshill added Type: Enhancement New feature or request Context: Accessibility Making interaction better for Everyone labels Oct 6, 2020
@tkshill tkshill added this to the Version 1.0 milestone Oct 6, 2020
@tkshill tkshill added this to To do in Elm Quarto Project via automation Oct 6, 2020
@tkshill tkshill added Status: Available This issue is free to be worked on. hacktoberfest tag for issues meant to be tackled during hacktoberfest. labels Oct 6, 2020
@dominicduffin1
Copy link
Collaborator

Hi! I'd like to take this on. Could you confirm - is the page.body also in Shared.elm and viewBoard the one in GamePage.elm.?

@tkshill tkshill added Status: Assigned Someone is already working on this issue and removed Status: Available This issue is free to be worked on. labels Oct 17, 2020
@tkshill
Copy link
Owner Author

tkshill commented Oct 17, 2020

Hey @dominicduffin1 ,

I've assigned you to the issue. The page.body in shared.elm is equivalent to the body of the top level record returned by view function in GamePage.elm.

So this page.body in Shared.elm

view :
    { page : Document msg, toMsg : Msg -> msg }
    -> Model
    -> Document msg
view { page } _ =
            ...
            , column [ height fill, centerX ] page.body
            ...

is this body in GamePage.elm

view : Model -> Document Msg
view model =
    { title = "Quarto - Play"
    , body =
        [ column [ spacing 10, centerX ]
           ...

@tkshill
Copy link
Owner Author

tkshill commented Oct 28, 2020

closed by #39

@tkshill tkshill closed this as completed Oct 28, 2020
Elm Quarto Project automation moved this from To do to Done Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Context: Accessibility Making interaction better for Everyone hacktoberfest tag for issues meant to be tackled during hacktoberfest. Status: Assigned Someone is already working on this issue Type: Enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants