New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ukrainian cities to proper spelling #29
Rename ukrainian cities to proper spelling #29
Conversation
@bgr11n Thank you for creating a PR, and I'm sorry for the late response.
You're right, so I will improve it later, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add it rather than rename it for backward compatibility?
@tkuchiki But in that case there will be duplicates? |
Yes. In that case, do you have any concerns? |
@tkuchiki No, just wanted to clarify that it is expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Please, rename ukrainian cities to use up-to-date spelling, examples from wiki:
Also maybe it make sense to have separately some id or slug field that should be persistent and name that may change?