Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ukrainian cities to proper spelling #29

Merged
merged 2 commits into from Apr 12, 2024

Conversation

bgr11n
Copy link
Contributor

@bgr11n bgr11n commented Mar 28, 2024

Please, rename ukrainian cities to use up-to-date spelling, examples from wiki:

Also maybe it make sense to have separately some id or slug field that should be persistent and name that may change?

@tkuchiki
Copy link
Owner

tkuchiki commented Apr 9, 2024

@bgr11n Thank you for creating a PR, and I'm sorry for the late response.
I will check it later.

Also maybe it make sense to have separately some id or slug field that should be persistent and name that may change?

You're right, so I will improve it later, thank you!

Copy link
Owner

@tkuchiki tkuchiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add it rather than rename it for backward compatibility?

timezones.go Show resolved Hide resolved
timezones.go Show resolved Hide resolved
timezones.go Show resolved Hide resolved
timezones.go Show resolved Hide resolved
timezones.go Show resolved Hide resolved
timezones.go Show resolved Hide resolved
tz_infos.go Outdated Show resolved Hide resolved
tz_infos.go Outdated Show resolved Hide resolved
tz_infos.go Outdated Show resolved Hide resolved
@bgr11n
Copy link
Contributor Author

bgr11n commented Apr 9, 2024

@tkuchiki But in that case there will be duplicates?

@tkuchiki
Copy link
Owner

Yes. In that case, do you have any concerns?

@bgr11n
Copy link
Contributor Author

bgr11n commented Apr 10, 2024

@tkuchiki No, just wanted to clarify that it is expected.

@bgr11n bgr11n requested a review from tkuchiki April 10, 2024 16:00
Copy link
Owner

@tkuchiki tkuchiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tkuchiki tkuchiki merged commit c999658 into tkuchiki:master Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants