Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LTIError no longer defined in lti_new.py #1365

Closed
jonespm opened this issue Apr 7, 2022 · 1 comment · Fixed by #1385
Closed

LTIError no longer defined in lti_new.py #1365

jonespm opened this issue Apr 7, 2022 · 1 comment · Fixed by #1385
Assignees
@lsloan @jonespm @zqian
Projects
MyLA-2022.01.02

Comments

@jonespm
Copy link
Member

jonespm commented Apr 7, 2022

Describe the bug (Tell us what happens instead of the expected behavior) :

I as a warning from Pylance that LTIError was not defined. "LTIError" is not defined

It looks like the class was removed in #1105 but used again in #1101. Not too sure what happened with this
@jonespm jonespm added this to To do in MyLA-2022.01.02 via automation May 11, 2022
@zqian zqian self-assigned this Jun 16, 2022
@zqian zqian moved this from To do to In progress in MyLA-2022.01.02 Jun 16, 2022
@zqian zqian mentioned this issue Jun 17, 2022
Merged
@zqian zqian moved this from In progress to QA in MyLA-2022.01.02 Jun 17, 2022
@zqian zqian moved this from QA to In progress in MyLA-2022.01.02 Jun 17, 2022
@zqian zqian moved this from In progress to QA-dev in MyLA-2022.01.02 Jun 23, 2022
@jonespm
Copy link
Member Author

jonespm commented Jun 27, 2022

Not sure how to test this but not seeing the error in VSCode anymore and looks good, so marking it as completed.

@jonespm jonespm moved this from QA-dev to Done in MyLA-2022.01.02 Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsloan lsloan

@jonespm jonespm

@zqian zqian

Labels
None yet
Projects
No open projects
MyLA-2022.01.02
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue_1365 update LTIError to lti_error zqian/my-learning-analytics
3 participants
@lsloan @jonespm @zqian