Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update d3 #1367

Closed
ssciolla opened this issue Apr 8, 2022 · 2 comments · Fixed by #1449
Closed

Update d3 #1367

ssciolla opened this issue Apr 8, 2022 · 2 comments · Fixed by #1449
Assignees
@pushyamig
Labels
backlog dependencies Pull requests that update a dependency file Frontend
Projects
MyLA-2022.02.01

Comments

@ssciolla
Copy link
Contributor

ssciolla commented Apr 8, 2022 •
edited

Upgrading d3 is a significant piece still to be done, and which I think we'll tackle separately. We're behind two major releases and the d3-tip companion library seems to have been archived on GitHub (https://github.com/caged/d3-tip). I found a migration guide for version 6, but no equivalent yet for version 7: https://observablehq.com/@d3/d3v6-migration-guide

Originally posted by @ssciolla in #1363 (comment)

As of now (4/8/22), I don't think d3 version 5 poses any vulnerabilities, but updating it is something we'll have to face at some point.
@ssciolla ssciolla added backlog dependencies Pull requests that update a dependency file Frontend labels Apr 8, 2022
@ssciolla ssciolla mentioned this issue Apr 8, 2022
Merged
17 tasks
@jonespm jonespm added this to To do in MyLA-2022.01.02 via automation May 11, 2022
@jennlove-um jennlove-um removed this from To do in MyLA-2022.01.02 May 25, 2022
@jennlove-um jennlove-um added this to To do in MyLA-Default-Project via automation May 25, 2022
@pushyamig pushyamig removed this from To do in MyLA-Default-Project Nov 3, 2022
@pushyamig pushyamig added this to To do in MyLA-2022.01.03 via automation Nov 3, 2022
@pushyamig pushyamig removed this from To do in MyLA-2022.01.03 Nov 3, 2022
@pushyamig pushyamig added this to To do in MyLA-2022.02.01 via automation Nov 3, 2022
@pushyamig pushyamig mentioned this issue Nov 3, 2022
Merged
@pushyamig pushyamig moved this from To do to In progress in MyLA-2022.02.01 Nov 3, 2022
@jennlove-um
Copy link
Contributor

Focus testing on Resources Accessed, Grade Distribution, and old Assignment Planning to verify nothing breaks.

MyLA-2022.02.01 automation moved this from In progress to Review/QA Nov 10, 2022
@jennlove-um
Copy link
Contributor

Testing passes in beta. Views are loading and filters are working with no errors.

@jennlove-um jennlove-um moved this from Review/QA to Done in MyLA-2022.02.01 Dec 14, 2022
@jonespm jonespm mentioned this issue Dec 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pushyamig pushyamig

Labels
backlog dependencies Pull requests that update a dependency file Frontend
Projects
No open projects
MyLA-2022.02.01
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the d3 to version7 pushyamig/my-learning-analytics
3 participants
@pushyamig @ssciolla @jennlove-um