New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the way instructor is identified during the LTI launch to avoid a misleading log message #1381
Comments
This is not something that will happen when users log in to MyLA via Canvas. This should still be reviewed and fixed as part of LTI certification. |
pushyamig
changed the title
Remove message "must be admin" from message when checking course_user_roles
Change the way instructor is identified during the LTI launch to avoid a misleading log message
Sep 1, 2022
Tested in beta:
|
I am moving this to done, for some reason this is moved to Review/QA- Dev |
Testing passes in test environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During the LTI certification, there were a few tests where they were sending short, unknown, or missing roles. However, the app printed that they "must be admin".
There's nothing that would indicate that they must be admin if they're not in the roles available. We should remove this message and maybe even log it as an ERROR.
my-learning-analytics/dashboard/lti_new.py
Line 194 in 2008dea
The Logic of the instructor check is modified for clarity and this avoids the flagged logged message
Test Plan:
TA in the course who is also an instructor in one of the course sections
. He should not enableMyLA for the course (start the data extraction )
auth_user
table. He is the person who canenable MyLA for the course
This will eliminate the unnecessary log message that certification flagged.
The text was updated successfully, but these errors were encountered: