Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to narrative text and structure #1479

Closed
ssciolla opened this issue Feb 13, 2023 · 4 comments · Fixed by #1486
Closed

Improvements to narrative text and structure #1479

ssciolla opened this issue Feb 13, 2023 · 4 comments · Fixed by #1486
Assignees
Labels
accessibility 🪳 bug Something isn't working 📈 enhancement New feature or request Frontend

Comments

@ssciolla
Copy link
Contributor

ssciolla commented Feb 13, 2023

When the Resources Accessed visualization was reviewed by the accessibility team, they had some recommendations regarding the narrative alternative text for the visualization. Some of these may also apply to the Grade Distribution chart.

  • Narrative should identify itself as an alternative to the visualization: This becomes more important with aria-hidden removed from the SVG. Something like "Following paragraphs provide a text description for graphical bar-chart on this page."
  • Structure narrative semantically: having the resources in a list instead of together in paragraphs would probably be slightly easier for users to parse.
  • Narrative should include if you have accessed a resource in the past: This information is included in the visual graph and folks reading the text description would also likely find it to be useful.

Views effected Grades and Resources

@ssciolla ssciolla added 🪳 bug Something isn't working 📈 enhancement New feature or request accessibility Frontend labels Feb 13, 2023
@jennlove-um jennlove-um added this to To do in MyLA-2023.01.02 via automation Feb 15, 2023
@ssciolla ssciolla removed their assignment Feb 16, 2023
@pushyamig pushyamig moved this from To do to In progress in MyLA-2023.01.02 Feb 28, 2023
MyLA-2023.01.02 automation moved this from In progress to Review/QA Mar 21, 2023
@gsilver
Copy link

gsilver commented Mar 27, 2023

Great work as always!

  1. Narratives identify themselves as alternatives to the visualizaton
  2. Narratives have inner structure
  3. Information on resources access is included

@jennlove-um
Copy link
Contributor

This works nicely as a narrative. It makes sense to group the items by those accessed and those not accessed and then list them from most often to least often accessed by other students in the class.

@jennlove-um jennlove-um moved this from Review/QA to Review/QA - DEV in MyLA-2023.01.02 Mar 29, 2023
@jennlove-um jennlove-um moved this from Review/QA - DEV to Done in MyLA-2023.01.02 Mar 29, 2023
@pushyamig
Copy link
Contributor

The change is also applied to Grade Distributions as well.

@jennlove-um
Copy link
Contributor

The narrative on Grade Distribution looks good as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 🪳 bug Something isn't working 📈 enhancement New feature or request Frontend
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants