Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console warning from class prop usage in SelectCard #1494

Closed
ssciolla opened this issue Mar 9, 2023 · 2 comments · Fixed by #1495
Closed

Console warning from class prop usage in SelectCard #1494

ssciolla opened this issue Mar 9, 2023 · 2 comments · Fixed by #1495
Assignees
Labels
🪳 bug Something isn't working Frontend

Comments

@ssciolla
Copy link
Contributor

ssciolla commented Mar 9, 2023

Thank you for contributing to this project!

  • Make sure to search the issues for duplicates first!

Expected behavior (A description of what you expected to happen) :

There should be no Web console errors or warnings when using the UI.

Describe the bug (Tell us what happens instead of the expected behavior) :

There is a warning about an invalid prop name of class (as opposed to className). I introduced this accidentally in PR #1475. The warning is suppressed in production, so there is no visible error there.

Steps to Reproduce :

  1. Launch MyLA from a course, check you're on the view/visualization page.
  2. Check the Web console.
@ssciolla ssciolla added 🪳 bug Something isn't working Frontend labels Mar 9, 2023
@ssciolla ssciolla self-assigned this Mar 9, 2023
@ssciolla ssciolla added this to To do in MyLA-2023.01.02 via automation Mar 9, 2023
MyLA-2023.01.02 automation moved this from To do to Review/QA Mar 17, 2023
@jennlove-um jennlove-um moved this from Review/QA to Review/QA - DEV in MyLA-2023.01.02 Mar 30, 2023
@pushyamig
Copy link
Contributor

I will QA this

@pushyamig
Copy link
Contributor

Test Passes. I don't see the error from any views including the home page. I ran the test from latest from my local

@pushyamig pushyamig moved this from Review/QA - DEV to Done in MyLA-2023.01.02 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working Frontend
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants