Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue for No Term from UDP course query #1504

Closed
jonespm opened this issue Apr 27, 2023 · 2 comments · Fixed by #1505
Closed

Resolve issue for No Term from UDP course query #1504

jonespm opened this issue Apr 27, 2023 · 2 comments · Fixed by #1505
Assignees

Comments

@jonespm
Copy link
Member

jonespm commented Apr 27, 2023

Zhen had a working fix for the UDP query on this other PR, should close this PR and open a new one with the fix

          Hmm, I pulled the list of all the course ids to use from our production to substitute in `%(course_ids)s` there are 537 courses defined there. 
SET SESSION group_concat_max_len = 16384;
select CONCAT("'", GROUP_CONCAT(id order by id SEPARATOR "','"), "'") from course where id is not null order by id;

The query on the PR 'as-is' only seems to return 51 rows, the query Zhen proposed returns 537 rows, our original query returns 537 rows.

So I'd probably close this one and @zqian can open one with her change.

Originally posted by @jonespm in #1499 (comment)

@jonespm
Copy link
Member Author

jonespm commented Apr 27, 2023

The query fix was at #1499 (comment)

@jonespm jonespm added this to To do in MyLA-2023.02.01 via automation Apr 27, 2023
@zqian zqian moved this from To do to In progress in MyLA-2023.02.01 Apr 27, 2023
@zqian zqian linked a pull request Apr 27, 2023 that will close this issue
MyLA-2023.02.01 automation moved this from In progress to Review/QA Apr 27, 2023
@jennlove-um
Copy link
Contributor

Tested in MyLA beta.

Adding a course with No Term worked. The course was added and there were no error messages in the cron log for the course.

@jennlove-um jennlove-um moved this from Review/QA to Done in MyLA-2023.02.01 Sep 14, 2023
MyLA-2023.02.01 automation moved this from Done to Review/QA Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
MyLA-2023.02.01
  
Review/QA
Development

Successfully merging a pull request may close this issue.

3 participants