Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Frontend Dependencies #1529

Closed
pushyamig opened this issue Aug 24, 2023 · 3 comments · Fixed by #1555
Closed

Upgrade to Frontend Dependencies #1529

pushyamig opened this issue Aug 24, 2023 · 3 comments · Fixed by #1555
Assignees
Labels

Comments

@pushyamig
Copy link
Contributor

pushyamig commented Aug 24, 2023

It's time we update the Myla Major FE libraries like React 8 and Material UI 5 we are one version behind. We are going to see a possible issue when Upgrading to ApolloClient as listed here #1525


Test Plan
https://docs.google.com/spreadsheets/d/18c_VDE7wdme8c36Zo5-pjad77Kit8hFz4ylbmFXmLP8/edit#gid=0

@jaydonkrooss
Copy link
Contributor

So this is my PR against @pushyamig's branch to address the styling regressions that we saw with the Material UI upgrade: pushyamig#11

Also just noting some other styling differences that Jennifer uncovered that we do not need to revert:

  • Assignment Planning: the "clear" and "clear filters" buttons are set to blue when enabled
  • Assignment Planning: the "Set a goal" input field is now a outlined text field rather than the standard underlined input

@pushyamig
Copy link
Contributor Author

MyLA-2024.01.01 automation moved this from In progress to Review/QA Jan 10, 2024
@jennlove-um
Copy link
Contributor

Testing passes in beta

@jennlove-um jennlove-um moved this from Review/QA to Done in MyLA-2024.01.01 Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants