Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not imported 'tot_psf' in psfmodels.__init__ #6

Closed
ZhenhongDu opened this issue Sep 20, 2022 · 3 comments · Fixed by #9
Closed

not imported 'tot_psf' in psfmodels.__init__ #6

ZhenhongDu opened this issue Sep 20, 2022 · 3 comments · Fixed by #9

Comments

@ZhenhongDu
Copy link

  • psfmodels version: latest version
  • Python version: 3.8
  • Operating System: Windows 10

Description

Recently, I installed PSFmodels on a new computer, and I found that the function 'tot_psf' were not imported in the psfmodels.__init__function, so when I used 'psf.tot_psf function', there was a mistake. I added it by myself. Did you forget it?

not imported in psfmodels.init

@ZhenhongDu
Copy link
Author

ZhenhongDu commented Sep 20, 2022

By the way, I want to ask that the NA value used in ex_lens = {**air_lens, 'NA': 0.01} is the illumination objective NA in tot_psf mode? In general, the illumination objective NA of our system does not fill the whole back focal plane. Should I use the reduced NA?

@tlambert03
Copy link
Owner

sorry about that, I removed it from the top level since I'm not sure how robust it is. I can add it back (but definitely use with some degree of caution and double check the source). You can still import it at

from psfmodels._core import tot_psf

In general, the illumination objective NA of our system does not fill the whole back focal plane. Should I use the reduced NA?

yep, any NA entered into a field here should be assumed to be the "effective" NA. If you use an iris or otherwise don't fill the BFP, your effective NA is lower than the nominal NA on the objective.

@ZhenhongDu
Copy link
Author

Ok, thank you for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants