Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version detection & change DSN #4

Merged
merged 9 commits into from Feb 13, 2022
Merged

Improve version detection & change DSN #4

merged 9 commits into from Feb 13, 2022

Conversation

tlambert03
Copy link
Owner

This changes the SENTRY_DSN to use the new napari organization I set up.

It also detects whether napari is installed in editable mode, and tries to use the git sha.

also adds more docstrings in general

@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #4 (bc1c844) into main (50a48ef) will decrease coverage by 4.88%.
The diff coverage is 70.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   99.53%   94.65%   -4.89%     
==========================================
  Files           3        3              
  Lines         215      243      +28     
==========================================
+ Hits          214      230      +16     
- Misses          1       13      +12     
Impacted Files Coverage Δ
napari_error_reporter/_util.py 87.87% <66.66%> (-12.13%) ⬇️
napari_error_reporter/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a48ef...bc1c844. Read the comment docs.

@tlambert03 tlambert03 merged commit b8719c3 into main Feb 13, 2022
@tlambert03 tlambert03 deleted the improve-version branch February 13, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant