Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log actual N reps #36

Open
tlancon opened this issue Jun 18, 2020 · 1 comment
Open

Log actual N reps #36

tlancon opened this issue Jun 18, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@tlancon
Copy link
Owner

tlancon commented Jun 18, 2020

Currently number of reps includes false reps

Add record in DB for the actual number of reps

@tlancon tlancon added the enhancement New feature or request label Jun 18, 2020
@tlancon tlancon added this to the barbellcv-0.3.0 milestone Jun 26, 2020
@tlancon
Copy link
Owner Author

tlancon commented Aug 14, 2020

Problem: something like a Clean and Jerk double might actually be 6 reps:
Clean + Front Squat + Jerk (3)
Clean + Front Squat + Jerk (3)

Or even 5 reps:
Clean (done quickly so includes front squat) + Jerk (2)
Clean + Front Squat + Jerk (3)

Logically parsing these can be difficult. If a lifter logs a snatch double, it's easy to write code that says "count the number of reps flagged only as snatch" for this set", which would ignore any reps counted as overhead squat. Thus the # reps for the double is 2.

For clean and jerk this isn't the case since each there is typically no "clean and jerk" rep, but a combination of other movements. barbellcv would have to know for each lift what flags count as valid reps. This could be added to lifts.json but is it worth adding this complexity?

@tlancon tlancon removed this from the barbellcv-0.3.0 milestone Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant