Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

A bunch of classes are unnecessarily marked final #12

Closed
archiecobbs opened this issue Jan 11, 2011 · 1 comment
Closed

A bunch of classes are unnecessarily marked final #12

archiecobbs opened this issue Jan 11, 2011 · 1 comment

Comments

@archiecobbs
Copy link

For example, EntiyContainer, EntityQuery, EntityQueryDefinition, EntityQueryFactory, LazyQueryView, BeanQueryFactory, CompositeItem...

Why? This just makes this add-on harder to use.

@tlaukkan
Copy link
Owner

Classes are marked final because they are not designed for inheritance and to allow for later changes in the class internals without breaking a lot of depending code base. It also aims to drive the developers to extend in the designed places. However the following classes are not final anymore: LazyQueryContainer, LazyQueryDefinition, EntityQueryDefinition. The classes which are left final are either designer to not be extended at any situation or so simple that it is easier just to copy the code.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants