Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @waldyrious to former maintainer #2257

Closed
agnivade opened this issue Aug 26, 2018 · 10 comments
Closed

Move @waldyrious to former maintainer #2257

agnivade opened this issue Aug 26, 2018 · 10 comments
Labels
community Issues/PRs dealing with role changes and community organization.

Comments

@agnivade
Copy link
Member

Hi, @waldyrious ! As you know, our
governance guidelines
define processes for keeping the list of organization members
in sync with the actual maintenance team.
Since you haven't been active in the project for a while now,
we'll be moving you to the status of former maintainer.

In practice, not much will change on your side,
since you'll remain a collaborator in the repos you have been active in,
so you will keep the ability to commit, merge PRs, label and close issues, etc.,
if you feel so inclined. But even if you don't,
keep in mind that every bit of work you already did for the tldr-pages project
was a voluntary gift of your time to this community.
Your efforts have contributed to a project
which helps hundreds of people every day — be proud of it!

And of course, you're welcome back anytime as a maintainer, if you so choose
— in which case we'll re-add you to the organization,
as is also described in the guidelines.
In any case, we wish you the best of luck in your new endeavors!

@agnivade
Copy link
Member Author

@waldyrious - Looks like you have accepted the invitation. Going to close out this issue now.

Hoping to see you back as a full time member soon !

@waldyrious
Copy link
Member

waldyrious commented Aug 26, 2018

Thanks for doing this, @agnivade -- it's my fault for not informing the community of my reduced availability, especially since I remained active elsewhere on github and gitter. I still have many plans for contributions I want to make to tldr-pages, so I'll definitely be returning as an active maintainer in the future. 😃

It's been a while since I worked on the documentation, but I believe the steps listed here don't mention the specific steps of:

  • actually removing the user from the org
  • adding the user as a collaborator in the repos
  • updating the list of current vs. previous owners (this one is mentioned but in an easy-to-miss form)

It's possible that these additions are being tracked in an issue, but if memory doesn't fail me, that's not the case. I think the instructions for removing owners should be listed in a step-by-step format similar to those for adding new owners.

For starters, I opened #2259 to make a few formatting changes to that document; I'd ask if you could add the remaining instructions afterwards, @agnivade (or @sbrl or @pxgamer) since I don't have access to the org management interface anymore to verify that the instructions are correct :)

@waldyrious
Copy link
Member

waldyrious commented Aug 26, 2018

Btw @agnivade I'm not sure if this is intentional but I only got an invitation to become a collaborator of the website repo (tldr-pages.github.io). I believe the guidelines may be a little ambiguous in this respect, but the passage here

If an organization member becomes inactive for over 6 months, their membership status should be equally deactivated. (They should nevertheless remain as collaborators in the repositories on which they have been active in the past.)

...doesn't apply any qualifiers to the "in the past", so I'd interpret it as not referring to the same latest-6-months period (or other similarly limited period). Do you read it otherwise? Or are guidelines elsewhere that contradict my interpretation?

Or perhaps this is just a delay on Github's part?

@agnivade
Copy link
Member Author

Yes, I agree "in the past" is not the 6 months duration. It should be the entire period of a person's activity.

I have sent you invitations for tldr-pages and tldr repo (I can still see a pending invitation for the tldr repo). I believe those are the repos to which you were active. Let me know if you were active in others too, and I will invite you.

@waldyrious
Copy link
Member

I can confirm that not getting the invitation for the main tldr repo was a Github issue. I got the email but for some reason it didn't appear in the notifications feed the same way the invitation for the website did.

As for which repos I was active in, I believe you're correct, yes. I'll let you know if I feel the need to get collaborator access in any of the other repos.

I would suggest not closing these issues until the user has accepted the relevant invitations, unless several days pass (e.g. they've been on an extended absence). This can also be added as part of the specific instructions I mentioned above. Does that make sense? I can open an issue to track that.

@sbrl
Copy link
Member

sbrl commented Aug 26, 2018

We'll be glad to have you back once you're ready, @waldyrious 😺

With respect to updating COMMUNITY-ROLES.md, a tracking issue sounds great if you could open one. I'm a little fuzzy on the details myself - so I'd need some clarification on a few points if I were to attempt it myself.

@sbrl sbrl added the community Issues/PRs dealing with role changes and community organization. label Aug 26, 2018
@waldyrious
Copy link
Member

Sure, will do. You being fuzzy in the details is precisely the type of situation we want to avoid with clearer documentation of the processes :)

@sbrl
Copy link
Member

sbrl commented Aug 26, 2018

Thanks, @waldyrious 😃

@agnivade
Copy link
Member Author

I would suggest not closing these issues until the user has accepted the relevant invitations,

Yes, I closed it once you accepted one of the invitations. Did not bother much with the other one since I thought you would be accepting that anyways after some time. But sure, its good to be done with everything and then close.

@waldyrious
Copy link
Member

Yeah, I didn't mean to write that directed as you (I fully trust that you had no ill intentions 🙂) but rather as a note to make sure that detail would be included in the more specific instructions that are now tracked in #2266.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Development

No branches or pull requests

3 participants