Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

[bug] Emojis Overlap #194

Closed
ggarnhart opened this issue May 24, 2022 · 2 comments
Closed

[bug] Emojis Overlap #194

ggarnhart opened this issue May 24, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@ggarnhart
Copy link

image

Line height probably needs to be adjust to account for emoji sizing.

JSON:

[
  {
    "id": "6f7f3d87-08e6-4dff-167d-55b21eee862e",
    "type": "text",
    "name": "Text",
    "parentId": "page",
    "childIndex": 101,
    "point": [
      4671.49,
      5086.49
    ],
    "rotation": 0,
    "text": "Line One ✅\nLine Two ✅\nLine Three✅",
    "style": {
      "color": "black",
      "size": "medium",
      "isFilled": false,
      "dash": "draw",
      "scale": 1.1688311688311692,
      "font": "sans",
      "textAlign": "start"
    }
  }
]

SVG:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 346 210" width="314" height="178" style="background-color: rgb(248, 249, 250);"><defs><style>@import url('https://fonts.googleapis.com/css2?family=Caveat+Brush&amp;family=Source+Code+Pro&amp;family=Source+Sans+Pro&amp;family=Crimson+Pro&amp;display=block');</style></defs><g text-align="left" text-anchor="start" fill="#1d1d1d" transform="translate(16.00, 16.00) rotate(0.00, 157.00, 89.00)"><text y="24" letter-spacing="-1.44" font-size="48px" font-family="Source Sans Pro" text-align="left" alignment-baseline="central" transform="scale(1.1688311688311692)">Line One ✅</text><text y="72" letter-spacing="-1.44" font-size="48px" font-family="Source Sans Pro" text-align="left" alignment-baseline="central" transform="scale(1.1688311688311692)">Line Two ✅</text><text y="120" letter-spacing="-1.44" font-size="48px" font-family="Source Sans Pro" text-align="left" alignment-baseline="central" transform="scale(1.1688311688311692)">Line Three✅</text></g></svg>
@ggarnhart ggarnhart added the bug Something isn't working label May 24, 2022
@steveruizok
Copy link
Contributor

This is a tough one. The line spacing for text is fairly tall by default, so we compress it using line-height I don't know how we would fix that for emojis. Any ideas?

@steveruizok
Copy link
Contributor

Can we reduce the font-size or paint size of just emojis?

@TodePond TodePond transferred this issue from tldraw/tldraw May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants