Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receiver goes deaf after some time #29

Closed
dev-zzo opened this issue Jan 16, 2018 · 6 comments
Closed

Receiver goes deaf after some time #29

dev-zzo opened this issue Jan 16, 2018 · 6 comments

Comments

@dev-zzo
Copy link

dev-zzo commented Jan 16, 2018

So this is an issue I have seen quite often on my setup: the receiver goes deaf after running for random period of time, no messages are decoded even though the signal strength has not changed. It seems hard to provide a reproducer though. :-/

After some staring at the code I seem to have managed to come up with a patch that, when applied, appears to mitigate the issue; at least, my systems now do not exhibit deafness any more.

dev-zzo@dfbd30b

Please let me know if I should make a pull request for you to integrate the changes.

@ckuethe
Copy link
Contributor

ckuethe commented Jan 16, 2018

I would argue that it's always worthwhile to make a PR, even for changes that may not be immediately integrated.

Anyhoo, I haven't seen this issue but I'll run your patch on my system to regression test it.

@ckuethe
Copy link
Contributor

ckuethe commented Jan 17, 2018

You should do up a PR. your patch doesn't break my system after about 28hrs of operation

@dev-zzo
Copy link
Author

dev-zzo commented Jan 18, 2018

Created pull request #32.

@TLeconte
Copy link
Owner

So, sometime complexity is not better.
I decided to switch from a 2nd order PLL to 1st order one. It does not change the result of my tests ...

No more Mska, no more problems.

@dev-zzo could you try y last commit ?

@dev-zzo
Copy link
Author

dev-zzo commented Jan 21, 2018

Would this change impact BER in a negative way?

@TLeconte
Copy link
Owner

Don't think so. There is theory and practice...
I have some test files and I don't get less decoded messages with this new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants