Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a case when the alias is not a proper sub path #177

Merged
merged 2 commits into from May 16, 2017
Merged

Fix a case when the alias is not a proper sub path #177

merged 2 commits into from May 16, 2017

Conversation

fatfisz
Copy link
Contributor

@fatfisz fatfisz commented May 15, 2017

I noticed it by an accident, but it seems fairly serious. There were no tests for this.

For example if an alias exists for components, then components_dummy should not be aliased, only components or components/*.

@fatfisz fatfisz requested a review from tleunen May 15, 2017 22:13
@codecov
Copy link

codecov bot commented May 15, 2017 •
edited

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/normalizeOptions.js 100% <100%> (ø) ⬆️

tleunen
tleunen approved these changes May 16, 2017
View reviewed changes
Copy link
Owner

@tleunen tleunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

@tleunen tleunen merged commit dcd5dca into master May 16, 2017
@tleunen tleunen deleted the fix-prefix-alias branch May 16, 2017 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tleunen tleunen tleunen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fatfisz @tleunen