Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the resolvePath option #195

Merged
merged 1 commit into from Jul 7, 2017
Merged

Add the resolvePath option #195

merged 1 commit into from Jul 7, 2017

Conversation

fatfisz
Copy link
Contributor

@fatfisz fatfisz commented Jun 11, 2017

Adds the getRealPath option, thus solving the #165 issue.

I used the getRealPath name, but maybe just transform would be good? But then getRealPath is exposed in the module... I just have a tiny doubt about the name. Maybe it would be good to instead expose transform and use that instead of getRealPath consistently.

I'm marking this as WIP because it depends on the changes from #194.

@codecov
Copy link

codecov bot commented Jun 11, 2017

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/utils.js 100% <100%> (ø) ⬆️
src/getRealPath.js 100% <100%> (ø)
src/normalizeOptions.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️
src/resolvePath.js

@fatfisz fatfisz changed the title WIP: Add the getRealPath option Add the resolvePath option Jun 21, 2017
@tleunen
Copy link
Owner

tleunen commented Jul 6, 2017

One issue I see is that a user who decide to defines resolvePath for a very specific use case has no way to call the default resolver (from the plugin) for all other paths.

@fatfisz
Copy link
Contributor Author

fatfisz commented Jul 7, 2017 via email

@tleunen
Copy link
Owner

tleunen commented Jul 7, 2017

Oh yes I see, indeed, the user can import the default function and use it explicitely as a fallback.

@tleunen tleunen merged commit 59115e0 into master Jul 7, 2017
@tleunen tleunen deleted the add-getrealpath-option branch July 7, 2017 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants