fix: Add support for custom resolvePath from babel plugin #109
Conversation
Codecov Report
|
There was a problem hiding this comment.
Sorry for the delay @johnny-c-jiang.
Minor comment, but it look good otherwise.
| @@ -98,12 +99,14 @@ exports.resolve = (source, file, opts) => { | |||
| cwd: options.cwd || projectRootDir, | |||
| root: options.root || [], | |||
| alias: options.alias || {}, | |||
| resolvePath: options.resolvePath, | |||
There was a problem hiding this comment.
Shouldn't this be resolvePath: options.resolvePath || resolvePath?
So that you can remove your line 108 and always get the src from pluginOptions.resolvePath?
There was a problem hiding this comment.
Shouldn't this be
resolvePath: options.resolvePath || resolvePath?
So that you can remove your line 108 and always get thesrcfrompluginOptions.resolvePath?
I thought about it. It's similar, but due to the importance of resolvePath function, I made the fallback assignment right before it's being used, so if there's a falsy value coming from options or plugin, the module still works.
Could make the suggested change if you feel strongly about it :)
There was a problem hiding this comment.
so if there's a falsy value coming from options or plugin, the module still works.
In theory, this should really never happen since resolvePath will be the first default value being set. So any falsy value will always result to using the default function.
But I see your point to make extra sure (especially without using typescript here), so I'll accept it ;)
tleunen
changed the title
babel-plugin-module-resolversupports customized resolver function whicheslint-import-resolver-babel-modulecurrently ignores, but should allow user to reuse