Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Add support for passing babelOptions to OptionsManager#init #113

Merged
merged 2 commits into from
Aug 24, 2020

Conversation

TuckerWhitehouse
Copy link
Contributor

@TuckerWhitehouse TuckerWhitehouse commented Aug 17, 2020

Taking the minimal approach to option 4 here #89 (comment)

My specific use case is to support passing rootMode: 'upward-optional'.

@tleunen
Copy link
Owner

tleunen commented Aug 18, 2020

Thank you @TuckerWhitehouse. I always appreciate contributions :)
It seems there are very small linting issues, but otherwise the changes look ok. I'm not always happy with adding new options, but if it helps some users, why not. But I wonder if that could be taken from the babel config instead of having to redefine something here? Or maybe I don't fully understand the usecase here

@TuckerWhitehouse
Copy link
Contributor Author

Hey @tleunen - So by default, babel will the current working directory as the root, but this setting instructs babel to search upward for a babel.config.js file which is useful in monorepos. The babel docs probably do a better job explaining it than I can :D https://babeljs.io/docs/en/options#rootmode

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #113 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/index.js 94.73% <100.00%> (+0.09%) ⬆️

@tleunen
Copy link
Owner

tleunen commented Aug 24, 2020

All good, thank you @TuckerWhitehouse :)

@tleunen tleunen merged commit c23f28d into tleunen:master Aug 24, 2020
@TuckerWhitehouse TuckerWhitehouse deleted the feature/babel-options branch August 24, 2020 16:17
@jcole356
Copy link

Looks like this has not been released? Any plans for a new release with this change?

@tleunen
Copy link
Owner

tleunen commented Oct 19, 2020

Oh I thought I had did one. Sorry. Will do now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants