Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Add default options value. #47

Merged
merged 1 commit into from
Mar 22, 2017
Merged

Add default options value. #47

merged 1 commit into from
Mar 22, 2017

Conversation

izaakschroeder
Copy link
Contributor

@izaakschroeder izaakschroeder commented Mar 13, 2017

Prevents options.extensions from failing when options is null.

Prevents `options.extensions` from failing when `options` is `null`.
@izaakschroeder izaakschroeder changed the title Fixes. Add default options value. Mar 13, 2017
izaakschroeder added a commit to metalabdesign/eslint-config-metalab that referenced this pull request Mar 13, 2017
If no options are provided, then the resolver blows up on trying to access an undefined variable.

See:
 * tleunen/eslint-import-resolver-babel-module#47
@tleunen
Copy link
Owner

tleunen commented Mar 13, 2017

Do you know when this can happen @izaakschroeder ?

@izaakschroeder
Copy link
Contributor Author

@tleunen Yes, when you have the configuration set like this:

settings['import/resolver'] = require.resolve('eslint-import-resolver-babel-module');

Which is valid but just sets options to be null.

@tleunen tleunen merged commit 5d297a7 into tleunen:master Mar 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants