Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Updates the DataTable component #246

Merged
merged 7 commits into from Mar 14, 2016
Merged

Updates the DataTable component #246

merged 7 commits into from Mar 14, 2016

Conversation

tleunen
Copy link
Owner

@tleunen tleunen commented Mar 5, 2016

Related to this #219

Currently this PR contains the selectable attribute alongside the new TableHeader component.

@tleunen tleunen force-pushed the datatable branch 5 times, most recently from 486bcbd to f0919f1 Compare March 8, 2016 02:01
@tleunen
Copy link
Owner Author

tleunen commented Mar 8, 2016

By any chances, @michaelguild13, @FoxxMD, do you know why Travis is failing on rendering the Table component? It's working fine locally oO

@tleunen tleunen force-pushed the datatable branch 6 times, most recently from a2f9a2d to 14f3df0 Compare March 10, 2016 01:32
@tleunen
Copy link
Owner Author

tleunen commented Mar 10, 2016

Ok I found the issue in the tests. It was because I used array.includes, which doesn't seem to be inside the chromium version used in Travis.

@tleunen tleunen force-pushed the datatable branch 5 times, most recently from 21c9fe6 to a01f9aa Compare March 13, 2016 00:59
tleunen added a commit that referenced this pull request Mar 14, 2016
Updates the DataTable component
@tleunen tleunen merged commit 4a0e55f into master Mar 14, 2016
@tleunen tleunen deleted the datatable branch March 14, 2016 00:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant