Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native hmac when possible #356

Closed
tomato42 opened this issue Sep 6, 2019 · 0 comments · Fixed by #419
Closed

Use native hmac when possible #356

tomato42 opened this issue Sep 6, 2019 · 0 comments · Fixed by #419
Labels
enhancement new feature to be implemented
Milestone

Comments

@tomato42
Copy link
Member

tomato42 commented Sep 6, 2019

with PR #355 we are using a pure-python implementation of HMAC, that also means that it is slower than necessary

make test vectors to that code, use it only when necessary (as a fallback)

@tomato42 tomato42 added enhancement new feature to be implemented help wanted labels Sep 6, 2019
@tomato42 tomato42 added this to the v0.8.0 milestone Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature to be implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant