Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illegal_parameter vs protocol_version #1339

Closed
kazu-yamamoto opened this issue Jan 30, 2024 · 3 comments
Closed

illegal_parameter vs protocol_version #1339

kazu-yamamoto opened this issue Jan 30, 2024 · 3 comments

Comments

@kazu-yamamoto
Copy link
Contributor

Sec 4.1.2. say:

A server which receives a legacy_version value not equal to 0x0303 MUST abort the handshake with an "illegal_parameter" alert.

Why isn't "protocol_version" used?

@davidben
Copy link
Contributor

protocol_version is defined as:

protocol_version: The protocol version the peer has attempted to
negotiate is recognized but not supported (see Appendix D).

The wrong value in legacy_version isn't negotiating the wrong version. It's just a syntax error.

@kazu-yamamoto
Copy link
Contributor Author

But E.2. says:

If the "supported_versions" extension is absent and the server only supports versions greater than ClientHello.legacy_version, the server MUST abort the handshake with a "protocol_version" alert.

In this case, "protocol_version" is used.
For simplicity, I would like to recommend "protocol_version" for the case above, too.

@ekr
Copy link
Contributor

ekr commented Feb 17, 2024

Absent more support, I propose to leave this as-is. At worst it's a judgement call and not an interop problem, and so I think out of scope for the 8446-bis effort. Target date: 2/29.

@ekr ekr closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants