Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible typo in the loss #25

Closed
many-hats opened this issue Mar 18, 2021 · 2 comments
Closed

Possible typo in the loss #25

many-hats opened this issue Mar 18, 2021 · 2 comments

Comments

@many-hats
Copy link

UPIT/upit/train/cyclegan.py

Line 132 in 1f272ea

self.learn.loss_func.D_B_loss = loss_D_A.detach().cpu()

Was this intended or was this line supposed to be:
self.learn.loss_func.D_B_loss = loss_D_B.detach().cpu() ?
@tmabraham
Copy link
Owner

Yes, this is indeed an error, thank you for catching it! But I think this does not affect training (the correct loss terms are backpropagated) and only affects the reporting of the losses. Nevertheless, I am surprised I didn't catch this earlier, and I am glad that you were able to find it.

I will fix it later today...

@tmabraham
Copy link
Owner

Fixed with 78d24f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmabraham @many-hats