Enable warnings for Clang.

alialib · Jul 13, 2018 · a5c82c6 · a5c82c6
1 parent 95e296f
commit a5c82c6
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -113,7 +113,8 @@ elseif(FIPS_MSVC)
     # Also suppress linker warnings about missing .pdb files that seem to inevitably creep in.
     add_link_options(/ignore:4099)
 elseif(FIPS_CLANG)
-    add_compile_options()
+    add_compile_options(-Wall -Werror)
+    add_compile_options(-Wno-logical-op-parentheses)
 endif()
 
 # Enable "big objects" for Visual C++ and try to speed up builds.

diff --git a/src/alia/signals/adaptors.hpp b/src/alia/signals/adaptors.hpp
@@ -33,7 +33,10 @@ struct readability_faker : signal<
     typename Wrapped::value_type const&
     read() const
     {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wnull-dereference"
         return *(typename Wrapped::value_type const*) nullptr;
+#pragma clang diagnostic pop
     }
     // LCOV_EXCL_STOP
     bool

diff --git a/src/alia/signals/basic.hpp b/src/alia/signals/basic.hpp
@@ -30,7 +30,10 @@ struct empty_signal : signal<Value, bidirectional_signal>
     Value const&
     read() const
     {
-        return *(Value*) nullptr;
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wnull-dereference"
+        return *(Value const*) nullptr;
+#pragma clang diagnostic pop
     }
     // LCOV_EXCL_STOP
     bool

diff --git a/src/alia/signals/core.hpp b/src/alia/signals/core.hpp
@@ -185,7 +185,10 @@ struct signal<Value, write_only_signal> : signal_interface<Value>
     Value const&
     read() const
     {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wnull-dereference"
         return *(Value const*) nullptr;
+#pragma clang diagnostic pop
     }
     // LCOV_EXCL_STOP
 };