Improve test coverage for logical operators.

alialib · Jul 6, 2018 · fde401f · fde401f
1 parent 4632413
commit fde401f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 18 deletions.
diff --git a/src/alia/signals/operators.hpp b/src/alia/signals/operators.hpp
@@ -87,15 +87,6 @@ struct logical_or_signal : signal<bool, read_only_signal>
                  || arg1_.is_readable() && arg1_.read();
         return value_;
     }
-    bool
-    is_writable() const
-    {
-        return false;
-    }
-    void
-    write(bool const& value) const
-    {
-    }
 
  private:
     Arg0 arg0_;
@@ -150,15 +141,6 @@ struct logical_and_signal : signal<bool, read_only_signal>
                 || arg1_.is_readable() && !arg1_.read());
         return value_;
     }
-    bool
-    is_writable() const
-    {
-        return false;
-    }
-    void
-    write(bool const& value) const
-    {
-    }
 
  private:
     Arg0 arg0_;

diff --git a/unit_tests/signals/operators.cpp b/unit_tests/signals/operators.cpp
@@ -64,6 +64,11 @@ TEST_CASE("signal &&", "[signals]")
     });
     REQUIRE(is_false(value(false) && access_counting_signal));
     REQUIRE(access_count == 0);
+
+    // Check that value ID is reasonable.
+    REQUIRE(
+        (value(true) && value(false)).value_id()
+        != (value(true) && value(true)).value_id());
 }
 
 TEST_CASE("signal ||", "[signals]")
@@ -90,6 +95,11 @@ TEST_CASE("signal ||", "[signals]")
     });
     REQUIRE(is_true(value(true) || access_counting_signal));
     REQUIRE(access_count == 0);
+
+    // Check that value ID is reasonable.
+    REQUIRE(
+        (value(false) || value(false)).value_id()
+        != (value(true) || value(false)).value_id());
 }
 
 TEST_CASE("select_signal", "[signals]")