Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly configure CI #95

Open
kba opened this issue Oct 24, 2016 · 10 comments
Open

Properly configure CI #95

kba opened this issue Oct 24, 2016 · 10 comments
Assignees
@kba

Comments

@kba
Copy link
Collaborator

kba commented Oct 24, 2016

It seems like the Circle CI continuous integration never worked. We can configure it with a circle.yml file, I can do that but I wouldn't know what to actually test beyond compilation.
@kba
Copy link
Collaborator Author

kba commented Oct 24, 2016

I'm actually able to configure the CircleCI setup from within the web interface. Upgraded to run on 14.04 now, trying to get the dependencies right.

@kba kba self-assigned this Oct 24, 2016
@zuphilip
Copy link
Collaborator

I am fine that the tests would just show us whether compilation is working or not. This sounds like a reasonable and doable start. Afterwards we could look closer at the tests which are already part of the repo, e.g. https://github.com/tmbdev/clstm/blob/master/run-tests

@kba
Copy link
Collaborator Author

kba commented Oct 24, 2016

https://github.com/tmbdev/clstm/blob/master/run-tests those are a bit heavy for testing PRs (multiple recompilations etc.)

@kba
Copy link
Collaborator Author

kba commented Oct 24, 2016 •
edited
Loading

Compilation works and CircleCI is training away on the cmu set https://circleci.com/gh/tmbdev/clstm/96. I'll wait and see how that goes but eventually I'll just set echo "No tests yet" as the test command so we can at least smoke test pull requests until we come up with a simpler test.

@kba
Copy link
Collaborator Author

kba commented Oct 24, 2016

After two hours CircleCI stopped the build. After disabling the test as described, build passes. Takes about 2:30 minutes for fetching dependencies and compiling.

@zuphilip
Copy link
Collaborator

Okay, this means we are testing currently if it can be installed, right?

@kba
Copy link
Collaborator Author

kba commented Oct 24, 2016

Right.

@tmbdev
Copy link
Owner

tmbdev commented Oct 27, 2016

Last I tried CI, the C++ compilers that the services had available were too outdated to work properly, and they lacked some C++ prerequisites. That's why I gave up on it temporarily.

TensorFlow uses Jenkins; maybe that's worth pursuing. CircleCI with Docker might be another route.

@kba
Copy link
Collaborator Author

kba commented Oct 28, 2016

Per default, CircleCI runs Ubuntu 12.04 containers but can be changed to 14.04 and after I did, it's a really nice service, easier to configure and more flexible than Travis, you can SSH into failed builds, parallelize etc.

@amitdo
Copy link
Contributor

amitdo commented Oct 28, 2016 •
edited
Loading

They added Ubuntu 14.04 support in Feb 2016.
It's now the Default OS for New Projects

g++ 4.8 and 4.9 are available. It's possible to download deb packages for newer g++ and cache them.

@kba kba mentioned this issue Oct 28, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kba kba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kba @tmbdev @zuphilip @amitdo