Py3 prints

[zuphilip]

The tsht-tests works for me locally with Python 2 as well as Python 3 and also Travis agreed. However, let us check this carefully and test some more examples.

[stweil]

2to3 does what the name says, namely convert code which was written for Python 2 to code which works with Python 3. It does not promise that it will still work with Python 2 after the conversion. Even if it seems to work at a first glance, here is an example of the problems with Python 2:

$ ./hocr-check -h
('usage:', './hocr-check', '[-o] file.html')

In Python 2 print is not a function, so the output includes everything which follows the print keyword which is not what we expect here.

I only see two possible solutions to support both versions of Python:

• Conditional code, that means one print statement for each version.
• Additional wrapper library. This is the commonly used solution.

[zuphilip]

Ah, okay, thank you for the explanation. One can include in every file with a print statement at the very beginning the statement:

from __future__ import print_function

I guess this is the wrapper library you mean?

[stweil]

Yes.

[zuphilip]

I guess this is not needed.

[stweil]

Yes, it should be removed.

[zuphilip]

Okay, I added the wrapper library to the files. Thus, we can test and discuss this further.

[stweil]

This one is also not needed.

[stweil]

Not needed, too.

[zuphilip]

I deleted the three unnecessary brackets. Please have a look at the new version.

[stweil]

@zuphilip, I changed the order of the commits and squashed two of them. This avoids unnecessary commits and asserts that the single commits don't break anything. I think that the PR is now ready to get merged.

[zuphilip]

Fine for me! Thanks for squashing the commits and reviewing.

[stweil]

Thank you for this PR. Merged now.