New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional styling #14
Conversation
Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
@CrazyIvan359 sorry I missed this, was on vacation and there were to many github notifications. Great PR! Before I can merge it we need some docs on the additional options. Can you please adapt the readme (e.g. adding the additional styling keys to the list)? |
No problem, hope it was a good one. I will get some docs added as soon as I can. What are your thoughts on removing |
Mhm I don't think we should remove it as it serves a different purpose than the flag you are proposing. The naming might not be ideal, but I think we should keep both |
Alright, I'll leave it in. I should have some time this weekend to write up some docs. |
sounds awesome 🚀 |
Docs added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the additional tests and the documentation - looks great 🚀
feature is released as part of version 1.3.0 |
This PR adds a several new methods of styling the
select
andcheckbox
promptshighlighted
token to style the choice being pointed touse_pointer
isFalse
text
token to style ordinary textdisabled
token to style disabled choicesbool
list
of token tuples to support custom stylinganswer
tokenselected
andhighlighted
tokens will have no effectI originally thought that
use_indicator
would serve the same purpose asuse_pointer
in this PR, but forselect
it turns on thecheckbox
style checkbox symbol. I suggest removing this option from theselect
prompt as well, but I wanted to discuss before making that change.questionary/questionary/prompts/select.py
Lines 53 to 55 in da7a2f9
This PR supersedes #12 and #13