Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: GTSAM 4.2 and boost 1.74 #23

Closed
2 of 4 tasks
tmcg0 opened this issue Dec 2, 2023 · 0 comments · Fixed by #37
Closed
2 of 4 tasks

Tracking issue: GTSAM 4.2 and boost 1.74 #23

tmcg0 opened this issue Dec 2, 2023 · 0 comments · Fixed by #37

Comments

@tmcg0
Copy link
Owner

tmcg0 commented Dec 2, 2023

upgrade dependency to GTSAM 4.2 and Boost 1.74

This was the prior note on upgrading to GTSAM 4.1.1, expecting at least this to need to be done:
Notes on upgrading for GTSAM 4.1.1
Major thing that changed which will impact bioslam should be the gtsam::Point3 interface. Point3 is just typedef'd to a vector3 now. So there's no more Point3::vector() or dot or cross. These are just namespaced functions to gtsam.

  • remove all gtsam::Point3::vector() calls. Just remove the vector() part, it's already typedef'd to a Vector3.
  • Point3::cross() -> gtsam::cross()
  • Point3::dot() -> gtsam::dot()
  • Point3::norm() -> gtsam::norm3()
@tmcg0 tmcg0 changed the title Tracking issue: upgrading to GTSAM 4.2 Tracking issue: near-term upgrades Dec 2, 2023
@tmcg0 tmcg0 changed the title Tracking issue: near-term upgrades Tracking issue: GTSAM 4.2 and boost 1.74 Dec 2, 2023
This was referenced Dec 3, 2023
@tmcg0 tmcg0 closed this as completed in #37 Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant