Partition [wip] #75
Closed
Partition [wip] #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now this falls into a fairly serious problem - if you have an array of length=4 and want 3 chunks, it's not possible to get 3 chunks with the `chunk()` underlying function, since the input must be integer, 1 will give 4 and 2 will give 2. So, we either need to change the expectation for the function, saying that it will _aim_ for the desired number of partitions, or not use `chunk()` under this.
Closed
|
Closing: needs a better defined problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this falls into a fairly serious problem - if you have an
array of length=4 and want 3 chunks, it's not possible to get 3 chunks
with the
chunk()underlying function, since the input must be integer,1 will give 4 and 2 will give 2.
So, we either need to change the expectation for the function, saying
that it will aim for the desired number of partitions, or not use
chunk()under this.