Skip to content

Commit

Permalink
test: use eslint.
Browse files Browse the repository at this point in the history
  • Loading branch information
tmcw committed Jan 18, 2019
1 parent b1b1c45 commit 0aa0dbd
Show file tree
Hide file tree
Showing 5 changed files with 369 additions and 81 deletions.
18 changes: 18 additions & 0 deletions lib/.eslintrc.js
@@ -0,0 +1,18 @@
module.exports = {
env: {
browser: true,
es6: true,
node: true
},
extends: "eslint:recommended",
parserOptions: {
ecmaVersion: 2015,
sourceType: "module"
},
rules: {
indent: ["off"],
"linebreak-style": ["error", "unix"],
quotes: ["error", "double"],
semi: ["error", "always"]
}
};
80 changes: 40 additions & 40 deletions lib/gpx.js
Expand Up @@ -25,9 +25,9 @@ function getLineStyle(extensions) {
}
// get the contents of multiple text nodes, if present
function getMulti(x, ys) {
let o = {},
n,
k;
let o = {};
let n;
let k;
for (k = 0; k < ys.length; k++) {
n = get1(x, ys[k]);
if (n) o[ys[k]] = nodeVal(n);
Expand All @@ -36,16 +36,16 @@ function getMulti(x, ys) {
}
function getProperties(node) {
let prop = getMulti(node, [
"name",
"cmt",
"desc",
"type",
"time",
"keywords"
]),
links = node.getElementsByTagName("link");
"name",
"cmt",
"desc",
"type",
"time",
"keywords"
]);
let links = node.getElementsByTagName("link");
if (links.length) prop.links = [];
for (let i = 0, link; i < links.length; i++) {
for (let i = 0; i < links.length; i++) {
prop.links.push(
Object.assign(
{ href: links[i].getAttribute("href") },
Expand All @@ -64,14 +64,14 @@ function get1(x, y) {

function coordPair(x) {
let ll = [
parseFloat(x.getAttribute("lon")),
parseFloat(x.getAttribute("lat"))
],
ele = get1(x, "ele"),
// handle namespaced attribute in browser
heartRate = get1(x, "gpxtpx:hr") || get1(x, "hr"),
time = get1(x, "time"),
e;
parseFloat(x.getAttribute("lon")),
parseFloat(x.getAttribute("lat"))
];
let ele = get1(x, "ele");
// handle namespaced attribute in browser
let heartRate = get1(x, "gpxtpx:hr") || get1(x, "hr");
let time = get1(x, "time");
let e;
if (ele) {
e = parseFloat(nodeVal(ele));
if (!isNaN(e)) {
Expand Down Expand Up @@ -100,11 +100,11 @@ function getRoute(node) {
};
}
function getPoints(node, pointname) {
let pts = node.getElementsByTagName(pointname),
line = [],
times = [],
heartRates = [],
l = pts.length;
let pts = node.getElementsByTagName(pointname);
let line = [];
let times = [];
let heartRates = [];
let l = pts.length;
if (l < 2) return {}; // Invalid line in GeoJSON
for (let i = 0; i < l; i++) {
let c = coordPair(pts[i]);
Expand All @@ -122,11 +122,11 @@ function getPoints(node, pointname) {
};
}
function getTrack(node) {
let segments = node.getElementsByTagName("trkseg"),
track = [],
times = [],
heartRates = [],
line;
let segments = node.getElementsByTagName("trkseg");
let track = [];
let times = [];
let heartRates = [];
let line;
for (let i = 0; i < segments.length; i++) {
line = getPoints(segments[i], "trkpt");
if (line) {
Expand Down Expand Up @@ -177,16 +177,16 @@ function getPoint(node) {
}

export function gpx(doc) {
let i,
tracks = doc.getElementsByTagName("trk"),
routes = doc.getElementsByTagName("rte"),
waypoints = doc.getElementsByTagName("wpt"),
// a feature collection
gj = {
type: "FeatureCollection",
features: []
},
feature;
let i;
let tracks = doc.getElementsByTagName("trk");
let routes = doc.getElementsByTagName("rte");
let waypoints = doc.getElementsByTagName("wpt");
// a feature collection
let gj = {
type: "FeatureCollection",
features: []
};
let feature;
for (i = 0; i < tracks.length; i++) {
feature = getTrack(tracks[i]);
if (feature) gj.features.push(feature);
Expand Down
23 changes: 0 additions & 23 deletions lib/kml.js
Expand Up @@ -38,29 +38,6 @@ function coord(v) {
.map(coord1);
}

function coordPair(x) {
let ll = [
parseFloat(x.getAttribute("lon")),
parseFloat(x.getAttribute("lat"))
],
ele = get1(x, "ele"),
// handle namespaced attribute in browser
heartRate = get1(x, "gpxtpx:hr") || get1(x, "hr"),
time = get1(x, "time"),
e;
if (ele) {
e = parseFloat(nodeVal(ele));
if (!isNaN(e)) {
ll.push(e);
}
}
return {
coordinates: ll,
time: time ? nodeVal(time) : null,
heartRate: heartRate ? parseFloat(nodeVal(heartRate)) : null
};
}

let serializer;

if (typeof XMLSerializer !== "undefined") {
Expand Down
3 changes: 2 additions & 1 deletion package.json
Expand Up @@ -10,7 +10,7 @@
"dist"
],
"scripts": {
"test": "jest",
"test": "eslint lib && jest",
"prepublish": "microbundle",
"release": "standard-version"
},
Expand All @@ -19,6 +19,7 @@
"babel-jest": "^23.6.0",
"babel-preset-env": "^1.7.0",
"cz-conventional-changelog": "^2.1.0",
"eslint": "^5.12.1",
"glob": "^7.0.5",
"jest": "^23.6.0",
"microbundle": "^0.9.0",
Expand Down

0 comments on commit 0aa0dbd

Please sign in to comment.