Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format JSON output #38

Merged
merged 1 commit into from Mar 9, 2022
Merged

Format JSON output #38

merged 1 commit into from Mar 9, 2022

Conversation

damms005
Copy link
Contributor

@damms005 damms005 commented Mar 5, 2022

This PR adds a new feature that ensures output that are JSON are nicely formatted

@tmdh
Copy link
Owner

tmdh commented Mar 9, 2022

Can you give me a tinker script to test?

@damms005
Copy link
Contributor Author

damms005 commented Mar 9, 2022

@tmdh please clarify what you mean by "tinker script"

The PR simply ensures that when you do something like User::all()->toJSON() or run any code that results in a JSON-like output, the output is a nicely-formatted JSON, rather than being squished together.

Refer to the before-and-after screenshots below:

BEFORE:

image

AFTER:

image

@tmdh
Copy link
Owner

tmdh commented Mar 9, 2022

LGTM

@tmdh tmdh merged commit 2703877 into tmdh:master Mar 9, 2022
@damms005
Copy link
Contributor Author

damms005 commented Mar 9, 2022

@tmdh post-merge comment: can I add a voice to PR 36? It is a good addition for Linux folks. I tested it and it worked flawlessly!

@luanfreitasdev
Copy link

There's no way to know exactly. But I believe that many prefer to install the deb to convert it. Looking for the empty icon is not practical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants