Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate reports/comments (potential issue) #45

Open
tmillr opened this issue Dec 27, 2022 · 0 comments
Open

Duplicate reports/comments (potential issue) #45

tmillr opened this issue Dec 27, 2022 · 0 comments

Comments

@tmillr
Copy link
Owner

tmillr commented Dec 27, 2022

The same commit might get reported more than once (e.g. a tag gets pushed, the same commit is pushed to multiple branches, etc.).

It appears that a separate workflow run occurs for each pushed tag. I assume that the commits array of the event/webhook payload will be empty if the tagged commit already exists on GitHub? but not if gh does not already have the commit that the pushed tag points to? if this is the case, then it probably shouldn't be necessary to ignore pushed tags in hopes of avoiding duplicate reports due to breaking change seeing the same commit twice or more (once for the pushed commit workflow run, and once for each pushed tag that points to that commit).

Potential Fixes

  • use a cache to note which commits have already been reported
  • warn users of this in docs/readme
  • investigate what happens when a tag gets pushed, how to avoid/ignore push events for tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant