Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing tests #11

Open
1 of 2 tasks
tmillr opened this issue May 2, 2023 · 1 comment
Open
1 of 2 tasks

failing tests #11

tmillr opened this issue May 2, 2023 · 1 comment

Comments

@tmillr
Copy link
Owner

tmillr commented May 2, 2023

  • Fix anything broken by VimResume, mainly :checktime on resume
  • Fix failing tests
@tmillr tmillr added 🧪 tests 🔬 needs investigation Unsure what's causing it labels May 6, 2023
@tmillr
Copy link
Owner Author

tmillr commented May 6, 2023

Unsure what's going on for should automatically check file times on resume.

The test passes on my system, but fails in CI? Very strange. I'm on macOS, CI is Ubuntu.

In CI the test is writing the file and changing it, and the autocmd is likely triggering, but :checktime doesn't do anything, not even when invoked manually.

Some ideas and things to try:

  • stat the file manually and compare the stat before and after changing the file
  • maybe nvim is hung up on a prompt? although I did check the mode via nvim_get_mode() and it returned normal mode and non-blocking
  • I checked the buf's filename, it is correct
  • the buf has the old content after :checktime, it is not getting the new changes
  • the buf is nomod after :checktime and the changes
  • see if there's a way to inspect vim's stored timestamp
  • maybe it's something specific to Linux stat call/struct (e.g. granularity of file size or something?), try larger changes maybe
  • try running ci on different os than Ubuntu
  • maybe there's a difference across os's in how file writes occur or affect stat info for pre-existing files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant