Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic open-source license information #21

Merged
merged 3 commits into from Nov 30, 2021
Merged

Add dynamic open-source license information #21

merged 3 commits into from Nov 30, 2021

Conversation

hisbaan
Copy link
Contributor

@hisbaan hisbaan commented Nov 30, 2021

This branch adds dynamic open-source license information. It is accessible via Settings > Open-Source Licenses. The list is generated upon compile time by a grade plugin as a JSON file, which is then used to render the list in the application.

video.1.mp4

@hisbaan hisbaan requested review from is-ahmed, Benson-chou and Just-Call-Sal and removed request for is-ahmed November 30, 2021 01:37
Copy link
Contributor

@Benson-chou Benson-chou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and clean!

Copy link
Contributor

@Just-Call-Sal Just-Call-Sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall code organization and documentation! I noticed that in build.gradle you changed "kotlinCompilerVersion" from 1.5.31 to 1.5.21, how come?

@hisbaan
Copy link
Contributor Author

hisbaan commented Nov 30, 2021

Good overall code organization and documentation! I noticed that in build.gradle you changed "kotlinCompilerVersion" from 1.5.31 to 1.5.21, how come?

I'm not sure, I'll remedy that

Copy link
Contributor

@Just-Call-Sal Just-Call-Sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! Looks good to me then 👍

@hisbaan hisbaan merged commit 0ccc62a into main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants