Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check user perference, make sure working #53

Closed
tmjeee opened this issue Mar 26, 2020 · 1 comment
Closed

Double check user perference, make sure working #53

tmjeee opened this issue Mar 26, 2020 · 1 comment
Assignees
Labels
question Further information is requested
Milestone

Comments

@tmjeee
Copy link
Owner

tmjeee commented Mar 26, 2020

No description provided.

@tmjeee tmjeee created this issue from a note in v1.0.0-beta Release Board (To do) Mar 26, 2020
@tmjeee tmjeee added this to the 1.0-beta milestone Mar 26, 2020
@tmjeee tmjeee self-assigned this Mar 26, 2020
@tmjeee tmjeee added the question Further information is requested label Mar 26, 2020
@tmjeee tmjeee moved this from To do to In Progress in v1.0.0-beta Release Board Mar 26, 2020
@tmjeee
Copy link
Owner Author

tmjeee commented Mar 26, 2020

This is how settings works

  • on log in it make a request and cached the settings in settings.service.ts
  • layouts upon init make request to BE and use those settings

Strictly speaking layout could just use the ones cached in settings.service.ts to save a few http calls
Right now it is working ok and I tend to just leave it that way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
No open projects
Development

No branches or pull requests

1 participant