Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "API Providers" to "Providers" #453

Merged
merged 7 commits into from May 14, 2022
Merged

Rename "API Providers" to "Providers" #453

merged 7 commits into from May 14, 2022

Conversation

jxom
Copy link
Member

@jxom jxom commented May 13, 2022

Description

Renaming "API Providers" to just "Providers" to be more aligned with ethers terminology. Also replaced references to the React Provider with WagmiProvider to avoid confusion and ambiguity.

@jxom jxom requested a review from tmm May 13, 2022 03:39
@changeset-bot
Copy link

changeset-bot bot commented May 13, 2022

⚠️ No Changeset found

Latest commit: 77150d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 3 packages
Name Type
@wagmi/core Minor
wagmi Minor
example-cra Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
wagmi ✅ Ready (Inspect) Visit Preview May 14, 2022 at 8:21PM (UTC)

Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid. Can we add a redirect for the Provider docs page too? Can set it up in _middleware.ts (there's another redirect already set up there as an example).

@@ -4,7 +4,7 @@ const config: HardhatUserConfig = {
networks: {
hardhat: {
forking: {
url: `https://eth-mainnet.alchemyapi.io/v2/${process.env.ALCHEMY_ID}`,
url: `https://eth-mainnet.alchemyapi.io/v2/PjT72qifrAFZ4WV_drrd30N5onftY5VA`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shite


import { CoinbaseWalletConnector } from 'wagmi/connectors/coinbaseWallet'
import { InjectedConnector } from 'wagmi/connectors/injected'
import { MetaMaskConnector } from 'wagmi/connectors/metaMask'
import { WalletConnectConnector } from 'wagmi/connectors/walletConnect'

import { alchemyProvider } from '../../../packages/core/apiProviders/alchemy'
import { alchemyProvider } from '../../../packages/core/providers/alchemy'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we import this from the wagmi package entrypoint?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, tried to do this, but it was yelling at me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed now

@codingwithmanny
Copy link
Sponsor Contributor

So thankful that we're renaming it to WagmiProvider, I usually ended up doing this as default.

@wevm wevm deleted a comment from codingwithmanny May 13, 2022
@tmm tmm merged commit 23b173e into main May 14, 2022
@tmm tmm deleted the jxom/rename-api-providers branch May 14, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants