New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "API Providers" to "Providers" #453
Conversation
|
Name | Type |
---|---|
@wagmi/core | Minor |
wagmi | Minor |
example-cra | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid. Can we add a redirect for the Provider docs page too? Can set it up in _middleware.ts
(there's another redirect already set up there as an example).
.config/hardhat.config.ts
Outdated
@@ -4,7 +4,7 @@ const config: HardhatUserConfig = { | |||
networks: { | |||
hardhat: { | |||
forking: { | |||
url: `https://eth-mainnet.alchemyapi.io/v2/${process.env.ALCHEMY_ID}`, | |||
url: `https://eth-mainnet.alchemyapi.io/v2/PjT72qifrAFZ4WV_drrd30N5onftY5VA`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shite
docs/components/core/Providers.tsx
Outdated
|
||
import { CoinbaseWalletConnector } from 'wagmi/connectors/coinbaseWallet' | ||
import { InjectedConnector } from 'wagmi/connectors/injected' | ||
import { MetaMaskConnector } from 'wagmi/connectors/metaMask' | ||
import { WalletConnectConnector } from 'wagmi/connectors/walletConnect' | ||
|
||
import { alchemyProvider } from '../../../packages/core/apiProviders/alchemy' | ||
import { alchemyProvider } from '../../../packages/core/providers/alchemy' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we import this from the wagmi package entrypoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, tried to do this, but it was yelling at me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed now
So thankful that we're renaming it to |
Description
Renaming "API Providers" to just "Providers" to be more aligned with ethers terminology. Also replaced references to the React
Provider
withWagmiProvider
to avoid confusion and ambiguity.