Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yajl-ruby dependency from 1.1.0 -> 1.2.0 #106

Merged
merged 1 commit into from Jan 11, 2015

Conversation

lencioni
Copy link
Contributor

yajl-ruby 1.2.0 was recently released and contains a number of changes:

brianmario/yajl-ruby@eef5c48...fb61daa

yajl-ruby 1.2.0 was recently released and contains a number of changes:

  brianmario/yajl-ruby@eef5c48...fb61daa
@vitaliel
Copy link

vitaliel commented Mar 5, 2014

Hi,
What do we need to merge this?

@XhmikosR
Copy link

Why stay with old versions if the new versions do not break anything?

@jimpo
Copy link

jimpo commented Dec 17, 2014

+1. Old version conflicts with other gems.

@benbalter
Copy link

@tmm1 if you're able to bump yajl-ruby to 1.2.0 without issue, I believe this will fix an issue whereby the default Jekyll configuration doesn't work on windows, uncovered while adding Windows testing over in github/pages-gem#112. Monkey patching the Gemfile to require 1.2.0 seems to work, fine, at least in the context of Jekyll, but I didn't test beyond that.

CCing for context, as it took a bit of digging to land here:

tmm1 added a commit that referenced this pull request Jan 11, 2015
Bump yajl-ruby dependency from 1.1.0 -> 1.2.0
@tmm1 tmm1 merged commit b125faf into pygments:master Jan 11, 2015
@benbalter
Copy link

✨ Thanks @tmm1!

@parkr Pygments master should now work on Windows out of the box.

@parkr
Copy link

parkr commented Jan 12, 2015

@parkr Pygments master should now work on Windows out of the box.

Thanks, @benbalter! 🎉 /cc @XhmikosR

@XhmikosR
Copy link

Awesome, thanks! Now, we only need a new gem published.

@amacneil
Copy link

Any chance you can publish a new gem?

@parkr
Copy link

parkr commented Jan 15, 2015

Bringing in the gem owners: /cc @tmm1 @tnm @vmg Thanks guys!

@XhmikosR
Copy link

Bump

@tmm1
Copy link
Contributor

tmm1 commented Jan 28, 2015

Published 0.6.1 to rubygems

@parkr
Copy link

parkr commented Jan 28, 2015

Thank you! 🎉 🎊 🙏 ❤️

@XhmikosR
Copy link

Thanks a million times! This indeed fixes the Windows issue with yajl-ruby and Ruby >= 2.x.

Now, we need a new pages-gem because it has 0.6.0 hardcoded...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants