New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest pygments #122
Conversation
👍 it's not in the Pygments changelog, but this also includes a new Handlebars lexer. |
Not sure why I didn't see the original cc: -- yay Inbox 3000. Confirmed that I still see that test failure locally. I'll 👀 this and see if any wisdom arises. |
That test will pass if we provide a lexer argument: diff --git a/test/test_pygments.rb b/test/test_pygments.rb
index 61df666..37c9835 100644
--- a/test/test_pygments.rb
+++ b/test/test_pygments.rb
@@ -88,7 +88,7 @@ class PygmentsHighlightTest < Test::Unit::TestCase
end
def test_highlight_works_with_single_character_input
- code = P.highlight("a")
+ code = P.highlight("a", :lexer => 'rb')
assert_match 'a</span>', code
end
@@ -283,5 +283,3 @@ class PygmentsConfigTest < Test::Unit::TestCase
assert list['Html'][:aliases].include?('html')
end
end
-
- I'm coming at this very fresh, though, so I don't know if requiring a test change is a bad sign, something related to the upgrade, or just noise. |
@rick Thanks for looking into this! |
Done in #127 |
Ran
rake vendor:update
.There is one failing test that seems like a legitimate failure. The test was added in d6a8f2a, which appears to be testing pipes and not necessarily the expected output.