Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend NodePort policy functional testing #67

Open
phenixblue opened this issue Oct 25, 2020 · 1 comment
Open

Extend NodePort policy functional testing #67

phenixblue opened this issue Oct 25, 2020 · 1 comment
Labels
ci enhancement New feature or request policy

Comments

@phenixblue
Copy link
Contributor

What would you like to be added:

Since #45 has now been merged we should be able to extend the functional testing for the NodePort policy.

Why is this needed:

We're currently not accurately testing the NodePort policies.

These tests require specific annotations on the target namespace for testing and will require a specifically formatted script that adheres to the pattern specified by the new functional testing framework.

@phenixblue phenixblue added enhancement New feature or request ci policy labels Oct 25, 2020
@phenixblue
Copy link
Contributor Author

Looking through the Service test manifests, there are some that I'm not 100% sure what they're suppose to be testing, so this may require some additional cleanup once we get started on this.

Specific manifest I'm not sure about:

  • test-svc04.yaml

We will also potentially need some additional tests for the various nodePort possibilities with relation of Service config to Namespace labels.

  • Label with invalid chars
  • Label with various combinations of ranged, single number, etc.

@ilrudie ilrudie self-assigned this Feb 2, 2021
@ilrudie ilrudie removed their assignment Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci enhancement New feature or request policy
Projects
None yet
Development

No branches or pull requests

2 participants