Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run spec throws an error #37

Closed
ghost opened this issue Sep 15, 2015 · 4 comments
Closed

npm run spec throws an error #37

ghost opened this issue Sep 15, 2015 · 4 comments

Comments

@ghost
Copy link

ghost commented Sep 15, 2015

npm run spec is throwing an error.
It appears that some requires for browserify no longer exists.
Are they no longer required?

 require('./spec/transform');
-require('./spec/type');
 require('./spec/undef');
-require('./spec/validator');
@tmpfs
Copy link
Owner

tmpfs commented Sep 15, 2015

Good catch, thanks, fixed in d7711b3.

Due to deleted test spec, updated for new test specs also.

@tmpfs
Copy link
Owner

tmpfs commented Sep 15, 2015

Furthermore, require-dir was not working with browserify so I shall write this file dynamically later, see #38.

@ghost
Copy link
Author

ghost commented Sep 15, 2015

actually I was looking to also update the developer section. Some npm modules like browserify and mdp needs to be install globally. That will be useful from newcomers to nodejs who might want to contribute

@tmpfs
Copy link
Owner

tmpfs commented Sep 16, 2015

Clarified requirements in 40e4f45, note that browserify is in devDependencies and the scripts should work fine after running npm i.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant