New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better markdown conversion control #184

Closed
neocotic opened this Issue May 13, 2013 · 2 comments

Comments

Projects
None yet
1 participant
@neocotic
Member

neocotic commented May 13, 2013

Update html.md to the latest version and add controls (i.e. options) for the conversion. For now, at least, these controls will be limited to the options that are provided by the library itself on a new markdown option which will be stored:

  • absolute - All copied URLs (e.g. for links and images) will be absolute
    • Extra care should be taken here since the library is called within the context of the background page, it's likely that this will resolve based on the background pages URL (additional parsing may be required)
  • inline - Generate links in Markdown using the inline style (include examples in description)

These new options will be accessible in a new Markdown section of the General tab on the options page. A brief description should be provided explaining what the options relate to.

The new options should also be made available as template variables (e.g. markdownAbsolute).

@ghost ghost assigned neocotic May 13, 2013

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic May 13, 2013

Member

I'm not sure absolute is a valid option any more since I just remembered that content.coffee already forces all links and images within the user selection to have absolute URLs.

This is probably still worthwhile for inline though.

Member

neocotic commented May 13, 2013

I'm not sure absolute is a valid option any more since I just remembered that content.coffee already forces all links and images within the user selection to have absolute URLs.

This is probably still worthwhile for inline though.

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic May 13, 2013

Member

This functionality has been added by PR #188.

Member

neocotic commented May 13, 2013

This functionality has been added by PR #188.

@neocotic neocotic closed this May 13, 2013

@neocotic neocotic added the accepted label Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment