This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Associate a timestamp to pulled packages #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following must be done before merge:
|
|
CC @Yatekii. Thoughts on the the added API and documentation? |
This impl. does not work with bitstreams that only contain global timestamps.
If GTS isn't discarded, an LTS in the next iteration will be incorrectly discarded instead.
|
Closes #5. |
|
https://crates.io/crates/embedded-time should be investigated to see if the API can be improved. Can we abstract the base and delta to an |
This was referenced Apr 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Decoder::pull_with_timestampthat associate a timestamp structure to a set of data packets. Local timestamps will monotonically increase a delta timestamp counter. Global timestamps will update a base timestamp, and reset the delta to zero, whenpulled from the bitstream.