Enable FormData being iterable

Now that this is supported in webidl2js, we can use it here. Closes #1671. Tests submitted to web-platform-tests/wpt#5741, but not included here yet; we'll do a web-platform-tests roll soon.
jsdom · May 1, 2017 · e3e4629 · e3e4629
1 parent 8d3f747
commit e3e4629
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/lib/jsdom/living/xhr/FormData-impl.js b/lib/jsdom/living/xhr/FormData-impl.js
@@ -66,6 +66,12 @@ exports.implementation = class FormDataImpl {
       this._entries.push(entry);
     }
   }
+
+  * [Symbol.iterator]() {
+    for (const entry of this._entries) {
+      yield [entry.name, idlUtils.tryWrapperForImpl(entry.value)];
+    }
+  }
 };
 
 function createAnEntry(name, value, filename) {

diff --git a/lib/jsdom/living/xhr/FormData.idl b/lib/jsdom/living/xhr/FormData.idl
@@ -11,5 +11,5 @@ interface FormData {
   boolean has(USVString name);
 //  void set(USVString name, USVString value); // as above
   void set(USVString name, Blob value, optional USVString filename);
-//  iterable<USVString, FormDataEntryValue>;
+  iterable<USVString, FormDataEntryValue>;
 };
diff --git a/test/web-platform-tests/index.js b/test/web-platform-tests/index.js
@@ -306,6 +306,7 @@ describe("Web Platform Tests", () => {
     "XMLHttpRequest/event-upload-progress.htm",
     "XMLHttpRequest/formdata-blob.htm",
     "XMLHttpRequest/formdata-delete.htm",
+    "XMLHttpRequest/formdata-foreach.html",
     "XMLHttpRequest/formdata-get.htm",
     "XMLHttpRequest/formdata-has.htm",
     "XMLHttpRequest/formdata-set.htm",