regular expression applied over the http header value

[yuqinlear]

I have some Http header value fails during the validation. I think the regexp works improper.
jsdom\lib\jsdom\living\helpers\headers.js line 11.

exports.fieldValueRegexp = /^[ \t]*(?:[\x21-\x7E\x80-\xFF](?:[ \t][\x21-\x7E\x80-\xFF])?)*[ \t]*$/;

test case:

fieldValueRegexp.test('a b'); //true
fieldValueRegexp.test('a b c'); //false
fieldValueRegexp.test('aa bb cc dd'); //true
fieldValueRegexp.test('this is a test'); //false

[domenic]

I don't understand the bug. What is the behavior you are seeing in jsdom that is different from browsers?

[yuqinlear]

Hi, @domenic
I have a header as X-our-own-header: the value is a fixed phrase.
The request fails as "the value is a fixed phrase." is invalid at jsdom, which behaves differently from my browser (chrome).
fieldValueRegexp.test('the value is a fixed phrase.') // false
Thank you!

[nicolashenry]

https://tools.ietf.org/html/rfc7230#section-3.2

     header-field   = field-name ":" OWS field-value OWS
     field-name     = token
     field-value    = *( field-content / obs-fold )
     field-content  = field-vchar [ 1*( SP / HTAB ) field-vchar ]
     field-vchar    = VCHAR / obs-text

     obs-fold       = CRLF 1*( SP / HTAB )
                    ; obsolete line folding
                    ; see Section 3.2.4

Maybe it should be /^[ \t]*(?:[\x20-\x7E\x80-\xFF](?:[ \t]+[\x20-\x7E\x80-\xFF])?)*[ \t]*$/ because '\x20' could be a "visible [USASCII] character" but I am not sure. Also note that 1*( SP / HTAB ) should give [ \t]+ and not [ \t].