Begin working on creating a BrowsingContext #1909
Conversation
There was a problem hiding this comment.
Which objects in jsdom are representing the Window vs. WindowProxy?
jsdom does not have WindowProxy at all right now. This is basically because WindowProxy is only relevant when you navigate, and even then only when you navigate a frame. It helps enforce that iframe.contentWindow stays the same object (a WindowProxy) even though the underlying global (a Window) completely changes.
I think it'll be important eventually, although for now I'd be OK with breaking that equality to get things off the ground, especially since (as noted in #1903) I am unsure about the performance implications. However, not having WindowProxy will probably make it very hard to pass a number of web platform tests related to navigation :-/.
Does “get the [[Foo]] Internal property of X” translate to approximately:
Yes, that sounds perfect.
|
|
||
| // 2. Call the JavaScript InitializeHostDefinedRealm() abstract operation | ||
| const window = new Window(); | ||
| // TODO: InitializeHostDefinedRealm({globalObject: window, globalThisValue: this.windowProxy, relmExecutionContext: new JavaScriptExecutionContext}) |
There was a problem hiding this comment.
I don't think this TODO is very actionable.
Creating a new realm is basically the vm.createContext() business, which the Window constructor takes care of. I'd maybe revise this to
// 2. Call ...
// In the current implementation, the Window() constructor takes care of creating a new realm via the vm module
| // https://html.spec.whatwg.org/#windows | ||
| class BrowsingContext { | ||
| // readonly windowProxy: WindowProxy | ||
| // readonly sessionHistory: SessionHistory |
| document: idlUtils.implForWrapper(this._document), | ||
| url: idlUtils.implForWrapper(this._document)._URL, | ||
| stateObject: null | ||
| }]; |
There was a problem hiding this comment.
So currently all the history-tracking is done by the History object, which hangs off of the window. I guess we need to disentangle them so that session history survives navigation. Then History will be an interface into a SessionHistory.
|
|
||
| // create a new browsing context | ||
| constructor() { | ||
| this.windowProxy = new WindowProxy(); |
There was a problem hiding this comment.
If we don't implement WindowProxy for now, we could just say this.windowProxy = window with a comment about how it's an interim solution, but the intent is that the public API presented by BrowsingContext can be reused later even when we implement a proper WindowProxy.
This is a work in progress, not ready to merge, but I’d appreciate assistance and pointers as I’m getting started.
Which objects in jsdom are representing the Window vs. WindowProxy?
Does “get the [[Foo]] Internal property of X” translate to approximately: